[sip-comm-dev] Re: Previews

Yana Stamcheva yana at sip-communicator.org
Mon Aug 16 13:49:37 CEST 2010


Hi Purvesh,

Thanks for adding all javadocs and fixing the alignment in the configuration form!

I spent some time testing the previews and I have some more remarks, mainly on the configuration form.  Here they are:

- Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".

- The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.

Keep up the good work!
Yana

On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:

> Hi Yana, 
> 
>  
> On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana at sip-communicator.org> wrote:
> Hey Purvesh,
> 
> It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> 
> I have a few very minor questions/comments.
> 
> When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> 
> 
> I've made these changes. I will commit them along with the javadocs.
>  
> I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> 
> 
> It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> 
>  
> Thanks,
> Purvesh 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at sip-communicator.dev.java.net
For additional commands, e-mail: dev-help at sip-communicator.dev.java.net





More information about the dev mailing list