[jitsi-issues] [JIRA] Issue Comment Edited: (JITSI-781) Log Chat History resets on restart

the_real_andrew (JIRA) jira-no-reply at java.net
Sun Apr 1 00:41:34 CEST 2012


    [ http://java.net/jira/browse/JITSI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=337108#action_337108 ] 

the_real_andrew edited comment on JITSI-781 at 3/31/12 10:40 PM:
-----------------------------------------------------------------

The problem appears to be in the *{{public void start(BundleContext bc)}}* function of jitsi/src/net/java/sip/communicator/impl/msghistory/MessageHistoryServiceImpl.java, which is on line 776.  It looks like it just checks for the existence of the sip-communicator.properties line, not whether it is configured for *{{true}}* or *{{false}}*:


Line 786-789:
{quote}
// Check if the message history is enabled in the configuration
// service, and if not do not register the service.
String isMessageHistoryEnabledPropertyString =
  "impl.msghistory.IS_MESSAGE_HISTORY_ENABLED";
{quote}

As a test, set the line

*{{net.java.sip.communicator.impl.msghistory.isMessageHistoryEnabled=purple}}* in ~/.jitsi/sip-communicator.properties and you still get log files created on start.

So two things here:
1. It's looking for the wrong line, it searches for *{{IS_MESSAGE_HISTORY_ENABLED}}* and not *{{isMessageHistoryEnabled}}*
2. It ignores the true or false setting.

      was (Author: the_real_andrew):
    The problem appears to be in the {{public void start(BundleContext bc)}} function of jitsi/src/net/java/sip/communicator/impl/msghistory/MessageHistoryServiceImpl.java, which is on line 776.  It looks like it just checks for the existence of the sip-communicator.properties line, not whether it is configured for {{true}} or {{false}}:


Line 786-789:
{{// Check if the message history is enabled in the configuration
// service, and if not do not register the service.
String isMessageHistoryEnabledPropertyString =
  "impl.msghistory.IS_MESSAGE_HISTORY_ENABLED";}}

As a test, set the line

{{net.java.sip.communicator.impl.msghistory.isMessageHistoryEnabled=purple}} in ~/.jitsi/sip-communicator.properties and you still get log files created on start.

So two things here:
1. It's looking for the wrong line, it searches for {{IS_MESSAGE_HISTORY_ENABLED}} and not {{isMessageHistoryEnabled}}
2. It ignores the true or false setting.
  
> Log Chat History resets on restart 
> -----------------------------------
>
>                 Key: JITSI-781
>                 URL: http://java.net/jira/browse/JITSI-781
>             Project: jitsi
>          Issue Type: Bug
>          Components: development
>    Affects Versions: current
>         Environment: Operating System: Linux
> Platform: PC
> URL: https://sip-communicator.dev.java.net/servlets/ReadMsg?list=users&msgNo=980
>            Reporter: the_real_andrew
>            Assignee: jitsi-issues
>             Fix For: 1.1
>
>
> I disabled Log Chat History by unchecking the option, and see this
> change in the ~/.sip-communicator/sip-communicator.properties file:
> service.gui.IS_MESSAGE_HISTORY_SHOWN=false
> net.java.sip.communicator.impl.msghistory.isMessageHistoryEnabled=false
> service.gui.MESSAGE_HISTORY_SIZE=10
> I quit s-c, restart it, and those lines are still set as you see there.
> However, "Log Chat History" is now checked, and I indeed do have chat
> history.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://java.net/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        




More information about the issues mailing list